Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Side by Side Diff: ui/app_list/views/app_list_main_view.cc

Issue 466693002: Fix app list DCHECKs getting hit when model updates occur during dragging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add test comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/app_list_main_view.h" 5 #include "ui/app_list/views/app_list_main_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
13 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
14 #include "ui/app_list/app_list_constants.h" 14 #include "ui/app_list/app_list_constants.h"
15 #include "ui/app_list/app_list_folder_item.h" 15 #include "ui/app_list/app_list_folder_item.h"
16 #include "ui/app_list/app_list_item.h" 16 #include "ui/app_list/app_list_item.h"
17 #include "ui/app_list/app_list_model.h" 17 #include "ui/app_list/app_list_model.h"
18 #include "ui/app_list/app_list_switches.h" 18 #include "ui/app_list/app_list_switches.h"
19 #include "ui/app_list/app_list_view_delegate.h" 19 #include "ui/app_list/app_list_view_delegate.h"
20 #include "ui/app_list/pagination_model.h" 20 #include "ui/app_list/pagination_model.h"
21 #include "ui/app_list/search_box_model.h" 21 #include "ui/app_list/search_box_model.h"
22 #include "ui/app_list/views/app_list_folder_view.h"
22 #include "ui/app_list/views/app_list_item_view.h" 23 #include "ui/app_list/views/app_list_item_view.h"
23 #include "ui/app_list/views/apps_container_view.h" 24 #include "ui/app_list/views/apps_container_view.h"
24 #include "ui/app_list/views/apps_grid_view.h" 25 #include "ui/app_list/views/apps_grid_view.h"
25 #include "ui/app_list/views/contents_switcher_view.h" 26 #include "ui/app_list/views/contents_switcher_view.h"
26 #include "ui/app_list/views/contents_view.h" 27 #include "ui/app_list/views/contents_view.h"
27 #include "ui/app_list/views/search_box_view.h" 28 #include "ui/app_list/views/search_box_view.h"
28 #include "ui/views/controls/textfield/textfield.h" 29 #include "ui/views/controls/textfield/textfield.h"
29 #include "ui/views/layout/box_layout.h" 30 #include "ui/views/layout/box_layout.h"
30 #include "ui/views/layout/fill_layout.h" 31 #include "ui/views/layout/fill_layout.h"
31 #include "ui/views/widget/widget.h" 32 #include "ui/views/widget/widget.h"
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 else 296 else
296 item->Activate(event_flags); 297 item->Activate(event_flags);
297 } 298 }
298 299
299 void AppListMainView::GetShortcutPathForApp( 300 void AppListMainView::GetShortcutPathForApp(
300 const std::string& app_id, 301 const std::string& app_id,
301 const base::Callback<void(const base::FilePath&)>& callback) { 302 const base::Callback<void(const base::FilePath&)>& callback) {
302 delegate_->GetShortcutPathForApp(app_id, callback); 303 delegate_->GetShortcutPathForApp(app_id, callback);
303 } 304 }
304 305
306 void AppListMainView::CancelDragInActiveFolder() {
307 contents_view_->apps_container_view()
308 ->app_list_folder_view()
309 ->items_grid_view()
310 ->EndDrag(true);
311 }
312
305 void AppListMainView::QueryChanged(SearchBoxView* sender) { 313 void AppListMainView::QueryChanged(SearchBoxView* sender) {
306 base::string16 query; 314 base::string16 query;
307 base::TrimWhitespace(model_->search_box()->text(), base::TRIM_ALL, &query); 315 base::TrimWhitespace(model_->search_box()->text(), base::TRIM_ALL, &query);
308 bool should_show_search = !query.empty(); 316 bool should_show_search = !query.empty();
309 contents_view_->ShowSearchResults(should_show_search); 317 contents_view_->ShowSearchResults(should_show_search);
310 UpdateSearchBoxVisibility(); 318 UpdateSearchBoxVisibility();
311 319
312 if (should_show_search) 320 if (should_show_search)
313 delegate_->StartSearch(); 321 delegate_->StartSearch();
314 else 322 else
(...skipping 10 matching lines...) Expand all
325 // Resubmit the query via a posted task so that all observers for the 333 // Resubmit the query via a posted task so that all observers for the
326 // uninstall notification are notified. 334 // uninstall notification are notified.
327 base::MessageLoop::current()->PostTask( 335 base::MessageLoop::current()->PostTask(
328 FROM_HERE, 336 FROM_HERE,
329 base::Bind(&AppListMainView::QueryChanged, 337 base::Bind(&AppListMainView::QueryChanged,
330 weak_ptr_factory_.GetWeakPtr(), 338 weak_ptr_factory_.GetWeakPtr(),
331 search_box_view_)); 339 search_box_view_));
332 } 340 }
333 341
334 } // namespace app_list 342 } // namespace app_list
OLDNEW
« no previous file with comments | « ui/app_list/views/app_list_main_view.h ('k') | ui/app_list/views/app_list_main_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698