Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: Source/devtools/front_end/TimelinePresentationModel.js

Issue 46663010: DevTools: Show GPU utilization bar on timeline (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tune PID to hue magic const Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelinePanel.js ('k') | Source/devtools/front_end/TracingAgent.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePresentationModel.js
diff --git a/Source/devtools/front_end/TimelinePresentationModel.js b/Source/devtools/front_end/TimelinePresentationModel.js
index c7e0c6e93eb51e7bd27b059d85a10f1e707e4b99..655cdfeae839cc564490ecace56771aff6aba956 100644
--- a/Source/devtools/front_end/TimelinePresentationModel.js
+++ b/Source/devtools/front_end/TimelinePresentationModel.js
@@ -229,6 +229,7 @@ WebInspector.TimelinePresentationModel._hiddenRecords[WebInspector.TimelineModel
WebInspector.TimelinePresentationModel._hiddenRecords[WebInspector.TimelineModel.RecordType.MarkLoad] = 1;
WebInspector.TimelinePresentationModel._hiddenRecords[WebInspector.TimelineModel.RecordType.ScheduleStyleRecalculation] = 1;
WebInspector.TimelinePresentationModel._hiddenRecords[WebInspector.TimelineModel.RecordType.InvalidateLayout] = 1;
+WebInspector.TimelinePresentationModel._hiddenRecords[WebInspector.TimelineModel.RecordType.GPUTask] = 1;
WebInspector.TimelinePresentationModel.prototype = {
/**
@@ -663,12 +664,14 @@ WebInspector.TimelinePresentationModel.prototype = {
var duration = endTime - startTime;
var offset = this._minimumRecordTime;
- var contentHelper = new WebInspector.PopoverContentHelper(WebInspector.UIString("CPU"));
+ var contentHelper = new WebInspector.PopoverContentHelper(info.name);
var durationText = WebInspector.UIString("%s (at %s)", Number.secondsToString(duration, true),
Number.secondsToString(startTime - offset, true));
contentHelper.appendTextRow(WebInspector.UIString("Duration"), durationText);
contentHelper.appendTextRow(WebInspector.UIString("CPU time"), Number.secondsToString(cpuTime, true));
contentHelper.appendTextRow(WebInspector.UIString("Message Count"), messageCount);
+ if (tasks[firstTaskIndex].pid)
+ contentHelper.appendTextRow(WebInspector.UIString("PID"), tasks[firstTaskIndex].pid);
return contentHelper.contentTable();
},
@@ -878,7 +881,7 @@ WebInspector.TimelinePresentationModel.insertRetrospectiveRecord = function(pare
{
return value < record.startTime ? -1 : 1;
}
-
+
parent.children.splice(insertionIndexForObjectInListSortedByFunction(record.startTime, parent.children, compareStartTime), 0, record);
}
@@ -1214,8 +1217,8 @@ WebInspector.TimelinePresentationModel.Record.prototype = {
if (typeof this.webSocketProtocol !== "undefined")
contentHelper.appendTextRow(WebInspector.UIString("WebSocket Protocol"), this.webSocketProtocol);
if (typeof this.data["message"] !== "undefined")
- contentHelper.appendTextRow(WebInspector.UIString("Message"), this.data["message"])
- break;
+ contentHelper.appendTextRow(WebInspector.UIString("Message"), this.data["message"]);
+ break;
default:
if (this.detailsNode())
contentHelper.appendElementRow(WebInspector.UIString("Details"), this.detailsNode().childNodes[1].cloneNode());
« no previous file with comments | « Source/devtools/front_end/TimelinePanel.js ('k') | Source/devtools/front_end/TracingAgent.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698