Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 466623002: Refactor PrivateScriptRunner.js to reduce the number of globally exposed variables (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
vivekg, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Refactor PrivateScriptRunner.js to reduce the number of globally exposed variables It's not a good idea to use global variables in PrivateScriptRunner.js because they are exposed to all window objects of the private scripts. This CL reduces the number of global variables used in PrivateScriptRunner.js. Also this CL removes a |global| parameter from installClass() since the |global| is always equal to the window object of the JS file. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180053

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -81 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.js View 1 2 chunks +66 lines, -69 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.js View 1 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/testing/PartialPrivateScriptTest.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/PrivateScriptTest.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
jl@: PTAL. This is a simple refactoring.
6 years, 4 months ago (2014-08-12 03:54:55 UTC) #1
Jens Widell
LGTM
6 years, 4 months ago (2014-08-12 04:41:15 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-12 05:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/466623002/20001
6 years, 4 months ago (2014-08-12 05:04:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 05:44:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 05:52:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20907)
6 years, 4 months ago (2014-08-12 05:52:45 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-12 08:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/466623002/40001
6 years, 4 months ago (2014-08-12 08:33:06 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 09:41:04 UTC) #10
Message was sent while issue was closed.
Change committed as 180053

Powered by Google App Engine
This is Rietveld 408576698