Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 466613002: Add validation logic for non-nullable types. (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, hansmuller
Project:
chromium
Visibility:
Public.

Description

Add validation logic for non-nullable types. This CL only turns on the non-nullable check for validation tests. There will be separate CLs for: - add DCHECK at the sending side. - make the existing APIs pass the non-nullable check and turn on the check everywhere. BUG=324170 TEST=New and revised validation tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290002

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : split serializtion/validation helper; don't like about the template specialization matching. #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -129 lines) Patch
M mojo/public/cpp/bindings/lib/array_internal.h View 1 2 3 9 chunks +88 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_good_null_struct.data View 1 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_good_null_struct.expected View 1 1 chunk +0 lines, -1 line 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_unexpected_null_struct.data View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd1_unexpected_null_struct.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_good_null_array.data View 1 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_good_null_array.expected View 1 1 chunk +0 lines, -1 line 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_unexpected_null_array.data View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd3_unexpected_null_array.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good_invalid_handle.data View 1 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good_invalid_handle.expected View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_handle_out_of_range.data View 1 2 3 1 chunk +23 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_1.data View 1 1 chunk +14 lines, -1 line 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_unexpected_invalid_handle.data View 1 2 3 4 chunks +5 lines, -7 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_unexpected_invalid_handle.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_good.data View 1 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_too_few_array_elements.data View 1 1 chunk +5 lines, -6 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_unexpected_null_fixed_array.data View 1 2 3 1 chunk +3 lines, -12 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd7_unexpected_null_fixed_array.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_good.data View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_good.expected View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_array.data View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_array.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_string.data View 1 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_unexpected_null_string.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good.data View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good.expected View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good_null_array.data View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_good_null_array.expected View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_unexpected_null_array.data View 1 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd9_unexpected_null_array.expected View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 2 3 1 chunk +28 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 3 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Darin and Tom. Would you please take a look? Thanks! Darin: everything except the ...
6 years, 4 months ago (2014-08-13 21:00:41 UTC) #1
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-13 21:39:09 UTC) #2
Tom Sepez
Q. Are we going to be able to extend this mechanism you've introduced to validate ...
6 years, 4 months ago (2014-08-15 17:12:00 UTC) #3
yzshen1
On 2014/08/15 17:12:00, Tom Sepez wrote: > Q. Are we going to be able to ...
6 years, 4 months ago (2014-08-15 17:29:08 UTC) #4
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-15 17:29:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/466613002/80001
6 years, 4 months ago (2014-08-15 17:30:47 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:34:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (80001) as 290002

Powered by Google App Engine
This is Rietveld 408576698