Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 466593002: GN: Fixes for component build (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw, eseidel
CC:
blink-reviews, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

GN: Fixes for component build This enables webkit_unit_tests and makes public/blink work in the component build. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180038

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M Source/web/BUILD.gn View 1 4 chunks +25 lines, -4 lines 0 comments Download
M public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jamesr
With some chromium side changes to fix up content this makes the unit tests link ...
6 years, 4 months ago (2014-08-12 03:29:46 UTC) #1
jamesr
On 2014/08/12 03:29:46, jamesr wrote: > With some chromium side changes to fix up content ...
6 years, 4 months ago (2014-08-12 03:30:00 UTC) #2
eseidel
rslgtm if you need it.
6 years, 4 months ago (2014-08-12 04:04:46 UTC) #3
brettw
woo! lgtm
6 years, 4 months ago (2014-08-12 04:09:59 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 04:26:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/466593002/20001
6 years, 4 months ago (2014-08-12 04:27:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 05:07:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 05:14:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20148) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19391)
6 years, 4 months ago (2014-08-12 05:14:29 UTC) #9
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 05:17:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/466593002/20001
6 years, 4 months ago (2014-08-12 05:17:52 UTC) #11
jamesr
On 2014/08/12 05:14:29, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-12 05:25:32 UTC) #12
eseidel
Filed crbug.com/402771.
6 years, 4 months ago (2014-08-12 05:40:57 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 06:20:44 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 07:00:19 UTC) #15
Message was sent while issue was closed.
Change committed as 180038

Powered by Google App Engine
This is Rietveld 408576698