Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 466583003: Files.app: Fix nits in FileOperationManager. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix nits in FileOperationManager. * Assign correct entry for entry-change event. * Assign totalBytes to processedBytes at the end of zipping. * Determine if entries are movable or not by comparing file system. BUG=None TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289291

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed. #

Patch Set 3 : Remove one assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -55 lines) Patch
M chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 6 chunks +28 lines, -50 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 4 months ago (2014-08-12 09:16:09 UTC) #1
mtomasz
https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode244 ui/file_manager/file_manager/background/js/file_operation_manager.js:244: (source.isFile ? parent.getFile : parent.getDirectory).call( Why the previous code ...
6 years, 4 months ago (2014-08-12 09:35:04 UTC) #2
hirono
https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode244 ui/file_manager/file_manager/background/js/file_operation_manager.js:244: (source.isFile ? parent.getFile : parent.getDirectory).call( On 2014/08/12 09:35:04, mtomasz ...
6 years, 4 months ago (2014-08-12 09:45:22 UTC) #3
mtomasz
lgtm https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode244 ui/file_manager/file_manager/background/js/file_operation_manager.js:244: (source.isFile ? parent.getFile : parent.getDirectory).call( On 2014/08/12 09:45:22, ...
6 years, 4 months ago (2014-08-13 01:05:55 UTC) #4
hirono
Thank you! https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/466583003/diff/1/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode247 ui/file_manager/file_manager/background/js/file_operation_manager.js:247: null , On 2014/08/13 01:05:55, mtomasz wrote: ...
6 years, 4 months ago (2014-08-13 04:32:15 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-13 04:32:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/466583003/20001
6 years, 4 months ago (2014-08-13 04:32:39 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 07:14:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 07:55:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3645)
6 years, 4 months ago (2014-08-13 07:55:02 UTC) #10
hirono
@mtomasz - I removed one assertion from the test. The assertion is not passed due ...
6 years, 4 months ago (2014-08-13 08:24:14 UTC) #11
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-13 08:24:17 UTC) #12
mtomasz
still lgtm
6 years, 4 months ago (2014-08-13 08:25:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/466583003/40001
6 years, 4 months ago (2014-08-13 08:29:37 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 11:18:56 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 11:40:48 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/5454)
6 years, 4 months ago (2014-08-13 11:40:49 UTC) #17
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-13 12:26:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/466583003/40001
6 years, 4 months ago (2014-08-13 12:26:40 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:45:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (40001) as 289291

Powered by Google App Engine
This is Rietveld 408576698