Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 466563002: Mojo: Make parallel sync/async embedder channel creation/destruction APIs. (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Make parallel sync/async embedder channel creation/destruction APIs. (I still have to write tests and convert some uses. I also want to add more logic to the async destruction, so that the |Channel| knows that it's about to be torn down.) R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -31 lines) Patch
M mojo/embedder/embedder.h View 1 chunk +62 lines, -22 lines 0 comments Download
M mojo/embedder/embedder.cc View 5 chunks +52 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-12 00:22:37 UTC) #1
yzshen1
LGTM
6 years, 4 months ago (2014-08-12 16:57:41 UTC) #2
viettrungluu
6 years, 4 months ago (2014-08-12 17:23:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 289015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698