Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466513002: Check that user has supplied at least one URL argument to quic_client (Closed)

Created:
6 years, 4 months ago by rjshade
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check that user has supplied at least one URL argument to quic_client BUG= Committed: https://crrev.com/abbfd37ef6db3e3012a55634a5487b50c1526b74 Cr-Commit-Position: refs/heads/master@{#292642}

Patch Set 1 : Rename args to urls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M net/tools/quic/quic_client_bin.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-22 04:36:47 UTC) #1
Robbie Shade
The CQ bit was checked by rjshade@google.com
6 years, 4 months ago (2014-08-22 13:40:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjshade@chromium.org/466513002/100001
6 years, 4 months ago (2014-08-22 13:41:14 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 14:35:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 15:28:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1431)
6 years, 4 months ago (2014-08-22 15:28:36 UTC) #6
Robbie Shade
The CQ bit was checked by rjshade@google.com
6 years, 3 months ago (2014-08-29 15:06:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjshade@chromium.org/466513002/100001
6 years, 3 months ago (2014-08-29 15:07:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:100001) as 14a669c1ac602f6694aae9d40a9963d9c01283e9
6 years, 3 months ago (2014-08-29 16:05:09 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:55 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/abbfd37ef6db3e3012a55634a5487b50c1526b74
Cr-Commit-Position: refs/heads/master@{#292642}

Powered by Google App Engine
This is Rietveld 408576698