Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 466483003: Fix crashes in ui::Compositor on Mac. (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 4 months ago
Reviewers:
jbauman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crashes in ui::Compositor on Mac. Ensure that all ui::CompositorObserver instances are unhooked from their ui::Compositor when the DelegatedFrameHost is destroyed. This was not being done in instances where RenderWidgetHostViewMac::Destroy was not being called before the destructor RenderWidgetHostViewMac::~RenderWidgetHostViewMac. BUG=401630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
Simple fix, should be the last critical one for ui::Compositor on Mac!
6 years, 4 months ago (2014-08-11 23:21:44 UTC) #1
jbauman
lgtm
6 years, 4 months ago (2014-08-11 23:23:02 UTC) #2
ccameron
Thanks!
6 years, 4 months ago (2014-08-11 23:28:16 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-11 23:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/466483003/1
6 years, 4 months ago (2014-08-11 23:32:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-12 00:23:41 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 03:17:30 UTC) #7
Message was sent while issue was closed.
Change committed as 288895

Powered by Google App Engine
This is Rietveld 408576698