Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 466393002: DevTools: Fix compile_frontend.py error reporting for frontend_modules.json (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix compile_frontend.py error reporting for frontend_modules.json R=lushnikov BUG=403309 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/devtools/scripts/compile_frontend.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
apavlov
6 years, 4 months ago (2014-08-13 13:16:49 UTC) #1
lushnikov
lgtm
6 years, 4 months ago (2014-08-13 13:27:13 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-13 13:27:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/466393002/1
6 years, 4 months ago (2014-08-13 13:28:11 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 13:28:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180170

Powered by Google App Engine
This is Rietveld 408576698