Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3397)

Unified Diff: chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc

Issue 466373004: [SyncFS] Introduce counters in LevelDBWrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc b/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
index c161e0cf5b1f656fff514388254368a7c8360bf8..0a594232efaea6d1f40a31de6712e4c2bb51461b 100644
--- a/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc
@@ -128,6 +128,9 @@ TEST_F(LevelDBWrapperTest, IteratorTest) {
EXPECT_TRUE(itr->Valid());
EXPECT_EQ("ab", itr->key().ToString());
EXPECT_EQ("0", itr->value().ToString());
+
+ EXPECT_EQ(0, GetDB()->num_puts());
+ EXPECT_EQ(1, GetDB()->num_deletes());
}
TEST_F(LevelDBWrapperTest, Iterator2Test) {
@@ -151,6 +154,10 @@ TEST_F(LevelDBWrapperTest, Iterator2Test) {
EXPECT_EQ(3, loop_counter);
EXPECT_EQ("c", prev_key);
EXPECT_EQ("3", prev_value);
+
+
nhiroki 2014/08/14 08:59:30 nit: extra blank line
peria 2014/08/14 09:01:53 Done.
+ EXPECT_EQ(3, GetDB()->num_puts());
+ EXPECT_EQ(0, GetDB()->num_deletes());
}
TEST_F(LevelDBWrapperTest, PutTest) {
@@ -168,8 +175,11 @@ TEST_F(LevelDBWrapperTest, PutTest) {
SCOPED_TRACE("PutTest_Pending");
CheckDBContents(merged_data, arraysize(merged_data));
+
nhiroki 2014/08/14 08:59:30 nit: ditto.
peria 2014/08/14 09:01:53 Done.
+ EXPECT_EQ(3, GetDB()->num_puts());
// Remove all pending transactions.
GetDB()->Clear();
+ EXPECT_EQ(0, GetDB()->num_puts());
SCOPED_TRACE("PutTest_Clear");
CheckDBContents(orig_data, arraysize(orig_data));
@@ -178,7 +188,9 @@ TEST_F(LevelDBWrapperTest, PutTest) {
GetDB()->Put("aa", "new0");
GetDB()->Put("c", "new1");
GetDB()->Put("bb", "new2");
+ EXPECT_EQ(3, GetDB()->num_puts());
GetDB()->Commit();
+ EXPECT_EQ(0, GetDB()->num_puts());
GetDB()->Clear(); // Clear just in case.
SCOPED_TRACE("PutTest_Commit");
@@ -199,6 +211,9 @@ TEST_F(LevelDBWrapperTest, DeleteTest) {
GetDB()->Delete("c"); // Remove a pending entry.
GetDB()->Delete("ab"); // Remove a committed entry.
+ EXPECT_EQ(3, GetDB()->num_puts());
+ EXPECT_EQ(2, GetDB()->num_deletes());
+
SCOPED_TRACE("DeleteTest_Pending");
CheckDBContents(merged_data, arraysize(merged_data));
@@ -217,6 +232,9 @@ TEST_F(LevelDBWrapperTest, DeleteTest) {
GetDB()->Commit();
GetDB()->Clear();
+ EXPECT_EQ(0, GetDB()->num_puts());
+ EXPECT_EQ(0, GetDB()->num_deletes());
+
SCOPED_TRACE("DeleteTest_Commit");
CheckDBContents(merged_data, arraysize(merged_data));
}

Powered by Google App Engine
This is Rietveld 408576698