Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 466373004: [SyncFS] Introduce counters in LevelDBWrapper (Closed)

Created:
6 years, 4 months ago by peria
Modified:
6 years, 4 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Introduce counters in LevelDBWrapper to count the number of pending transactions for PUT/DELETE operations independently. It means that both counters counts the operation for the entry, if an entry is put and deleted. BUG=347425 TEST=./unit_tests --gtest_filter="LevelDBWrapper*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289595

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Work for nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc View 1 6 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
peria
PTL. This CL will help http://crrev.com/455263003
6 years, 4 months ago (2014-08-14 05:44:28 UTC) #1
tzik
lgtm
6 years, 4 months ago (2014-08-14 05:52:28 UTC) #2
peria
Hiroki-san, Would you take a look, if you have time? It is OK to leave ...
6 years, 4 months ago (2014-08-14 08:50:20 UTC) #3
nhiroki
LGTM! https://codereview.chromium.org/466373004/diff/20001/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h File chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h (right): https://codereview.chromium.org/466373004/diff/20001/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h#newcode92 chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h:92: // Return the number of pending PUT/DELETE operations. ...
6 years, 4 months ago (2014-08-14 08:59:31 UTC) #4
peria
Thanks! https://codereview.chromium.org/466373004/diff/20001/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h File chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h (right): https://codereview.chromium.org/466373004/diff/20001/chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h#newcode92 chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h:92: // Return the number of pending PUT/DELETE operations. ...
6 years, 4 months ago (2014-08-14 09:01:53 UTC) #5
peria
The CQ bit was checked by peria@chromium.org
6 years, 4 months ago (2014-08-14 09:02:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/466373004/40001
6 years, 4 months ago (2014-08-14 09:03:48 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:21:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (40001) as 289595

Powered by Google App Engine
This is Rietveld 408576698