Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466363009: Restore text alloc optimizations. (Closed)

Created:
6 years, 4 months ago by jvanverth1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Restore text vertex buffer alloc and other optimizations. Modifies the fontcache GM to ensure that the font cache is forced to flush. Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca Committed: https://skia.googlesource.com/skia/+/63b9dc82474a4daf195c6157a711be401f7a0ddd

Patch Set 1 #

Patch Set 2 : Fix crash + clean up. #

Total comments: 10

Patch Set 3 : Fix nits. #

Patch Set 4 : Rebase to ToT #

Total comments: 1

Patch Set 5 : Fix some dumb bugs; rebase to ToT #

Patch Set 6 : Rebase to ToT (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -210 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M gm/fontcache.cpp View 1 3 chunks +8 lines, -24 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 13 chunks +65 lines, -81 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 13 chunks +69 lines, -87 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
jvanverth1
jvanverth@google.com changed reviewers: + bsalomon@google.com, robertphillips@google.com
6 years, 3 months ago (2014-08-26 20:24:46 UTC) #1
jvanverth1
6 years, 3 months ago (2014-08-26 20:25:04 UTC) #2
bsalomon
lgtm w/ a q and some nits https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp File src/gpu/GrBitmapTextContext.cpp (right): https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp#newcode269 src/gpu/GrBitmapTextContext.cpp:269: SkAutoKern autokern; ...
6 years, 3 months ago (2014-08-27 14:32:01 UTC) #3
jvanverth1
https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp File src/gpu/GrBitmapTextContext.cpp (right): https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp#newcode269 src/gpu/GrBitmapTextContext.cpp:269: SkAutoKern autokern; On 2014/08/27 14:32:00, bsalomon wrote: > What ...
6 years, 3 months ago (2014-08-27 15:09:35 UTC) #4
jvanverth1
https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp File src/gpu/GrBitmapTextContext.cpp (right): https://codereview.chromium.org/466363009/diff/20001/src/gpu/GrBitmapTextContext.cpp#newcode323 src/gpu/GrBitmapTextContext.cpp:323: allocateVertices(text, byteLength); On 2014/08/27 14:32:00, bsalomon wrote: > this-> ...
6 years, 3 months ago (2014-08-27 15:32:00 UTC) #5
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 3 months ago (2014-08-27 15:32:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/466363009/40001
6 years, 3 months ago (2014-08-27 15:32:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 15:32:10 UTC) #8
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-08-27 15:32:11 UTC) #9
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 3 months ago (2014-08-27 15:43:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/466363009/60001
6 years, 3 months ago (2014-08-27 15:44:13 UTC) #11
robertphillips
nit https://codereview.chromium.org/466363009/diff/60001/src/gpu/GrDistanceFieldTextContext.h File src/gpu/GrDistanceFieldTextContext.h (right): https://codereview.chromium.org/466363009/diff/60001/src/gpu/GrDistanceFieldTextContext.h#newcode46 src/gpu/GrDistanceFieldTextContext.h:46: Fields are supposed to go before methods.
6 years, 3 months ago (2014-08-27 15:45:43 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca
6 years, 3 months ago (2014-08-27 18:53:25 UTC) #13
djsollen
A revert of this CL (patchset #4) has been created in https://codereview.chromium.org/510103003/ by djsollen@google.com. The ...
6 years, 3 months ago (2014-08-27 20:11:46 UTC) #14
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 3 months ago (2014-08-28 12:59:46 UTC) #15
jvanverth1
The CQ bit was unchecked by jvanverth@google.com
6 years, 3 months ago (2014-08-28 12:59:52 UTC) #16
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 3 months ago (2014-08-28 13:55:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/466363009/80001
6 years, 3 months ago (2014-08-28 13:56:15 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 16:59:40 UTC) #19
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-08-28 16:59:41 UTC) #20
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 3 months ago (2014-08-28 17:31:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/466363009/100001
6 years, 3 months ago (2014-08-28 17:32:09 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 63b9dc82474a4daf195c6157a711be401f7a0ddd
6 years, 3 months ago (2014-08-28 17:39:46 UTC) #23
mtklein
6 years, 3 months ago (2014-08-29 13:56:20 UTC) #24
Message was sent while issue was closed. 
A revert of this CL (patchset #6) has been created in
https://codereview.chromium.org/518823002/ by mtklein@google.com.

The reason for reverting is: asserts in debug layout tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698