Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466363003: Oilpan: Compile error with GYP_DEFINES='gc_profile_marking=1' (Closed)

Created:
6 years, 4 months ago by Daniel Chow
Modified:
6 years, 4 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: Compile error with GYP_DEFINES='gc_profile_marking=1' 1. change the ENABLE(GC_TRACING) to ENABLE(GC_PROFILE_MARKING). R=ager@chromium.org, oilpan-reviews@chromium.org BUG=405009 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Chow
6 years, 4 months ago (2014-08-19 10:42:49 UTC) #1
zerny-chromium
LGTM, thanks for catching that miss.
6 years, 4 months ago (2014-08-19 11:30:12 UTC) #2
haraken
LGTM
6 years, 4 months ago (2014-08-19 11:31:59 UTC) #3
Daniel Chow
The CQ bit was checked by zhishun.zhou@samsung.com
6 years, 4 months ago (2014-08-20 01:56:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhishun.zhou@samsung.com/466363003/1
6 years, 4 months ago (2014-08-20 01:57:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-20 03:00:24 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 03:47:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180623

Powered by Google App Engine
This is Rietveld 408576698