Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 466353002: Added a console warning when <picture><source src></picture> is used. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added usecounter the right way Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 778
779 case WebSocketURL: 779 case WebSocketURL:
780 return "'WebSocket.URL' is deprecated. Please use 'WebSocket.url' instea d."; 780 return "'WebSocket.URL' is deprecated. Please use 'WebSocket.url' instea d.";
781 781
782 case HTMLTableElementVspace: 782 case HTMLTableElementVspace:
783 return "The 'vspace' attribute on table is deprecated. Please use CSS in stead."; 783 return "The 'vspace' attribute on table is deprecated. Please use CSS in stead.";
784 784
785 case HTMLTableElementHspace: 785 case HTMLTableElementHspace:
786 return "The 'hspace' attribute on table is deprecated. Please use CSS in stead."; 786 return "The 'hspace' attribute on table is deprecated. Please use CSS in stead.";
787 787
788 case PictureSourceSrc:
789 return "<source src> with a <picture> parent is invalid and therefore ig nored. Please use <source srcset> instead.";
790
788 // Features that aren't deprecated don't have a deprecation message. 791 // Features that aren't deprecated don't have a deprecation message.
789 default: 792 default:
790 return String(); 793 return String();
791 } 794 }
792 } 795 }
793 796
794 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 797 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
795 { 798 {
796 ASSERT(feature >= firstCSSProperty); 799 ASSERT(feature >= firstCSSProperty);
797 ASSERT(feature <= lastCSSProperty); 800 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
826 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 829 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
827 { 830 {
828 // FIXME: We may want to handle stylesheets that have multiple owners 831 // FIXME: We may want to handle stylesheets that have multiple owners
829 // http://crbug.com/242125 832 // http://crbug.com/242125
830 if (sheetContents && sheetContents->hasSingleOwnerNode()) 833 if (sheetContents && sheetContents->hasSingleOwnerNode())
831 return getFrom(sheetContents->singleOwnerDocument()); 834 return getFrom(sheetContents->singleOwnerDocument());
832 return 0; 835 return 0;
833 } 836 }
834 837
835 } // namespace blink 838 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698