Chromium Code Reviews

Issue 466333005: Add UMA stats for received frames or not in video track adapter. (Closed)

Created:
6 years, 4 months ago by Henrik Grunell
Modified:
6 years, 4 months ago
Reviewers:
Alexei Svitkine (slow), mcasas, tommi (sloooow) - chröme
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add UMA stats for received frames or not in video track adapter. The adapter is torn down when a session is ended (no more tracks connected to it), so we do the logging in the destructor. BUG=399835 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289939

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review #

Unified diffs Side-by-side diffs Stats (+17 lines, -0 lines)
M content/renderer/media/video_track_adapter.cc View 2 chunks +3 lines, -0 lines 0 comments
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments

Messages

Total messages: 10 (0 generated)
Henrik Grunell
6 years, 4 months ago (2014-08-14 15:32:31 UTC) #1
mcasas
lgtm
6 years, 4 months ago (2014-08-14 15:49:56 UTC) #2
mcasas
lgtm
6 years, 4 months ago (2014-08-14 15:49:57 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/466333005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/466333005/diff/1/tools/metrics/histograms/histograms.xml#newcode11444 tools/metrics/histograms/histograms.xml:11444: +<histogram name="Media.VideoTrackAdapter.FramesReceived" enum="Boolean"> Can you use a more specific ...
6 years, 4 months ago (2014-08-14 15:56:11 UTC) #4
Henrik Grunell
Code review fixes. Miguel: I can't see any stats registered. Can you take a look ...
6 years, 4 months ago (2014-08-14 21:23:32 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-14 21:27:33 UTC) #6
tommi (sloooow) - chröme
lgtm
6 years, 4 months ago (2014-08-15 13:50:48 UTC) #7
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 4 months ago (2014-08-15 14:02:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/466333005/20001
6 years, 4 months ago (2014-08-15 14:04:25 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:17:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289939

Powered by Google App Engine