Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 466323004: The GestureRecognizer should never map an ID to a NULL consumer (Closed)

Created:
6 years, 4 months ago by tdanderson
Modified:
6 years ago
Reviewers:
tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

The GestureRecognizer should never map an ID to a NULL consumer The current implementation of GestureRecognizerImpl::GetTargetForGestureEvent() will insert a mapping between a touch ID and a NULL GestureConsumer to |touch_id_target_for_gestures_| if queried with a touch ID that does not already exist in the map. Use .at() instead of [] to avoid this possibility. BUG=403346 TEST=none Committed: https://crrev.com/e59a6e0f1513a92ceaf4725171cee420214b2c3b Cr-Commit-Position: refs/heads/master@{#307986}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/events/gestures/gesture_recognizer_impl.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
https://codereview.chromium.org/466323004/diff/1/ui/events/gestures/gesture_recognizer_impl.cc File ui/events/gestures/gesture_recognizer_impl.cc (right): https://codereview.chromium.org/466323004/diff/1/ui/events/gestures/gesture_recognizer_impl.cc#newcode92 ui/events/gestures/gesture_recognizer_impl.cc:92: NOTREACHED() << "Touch ID does not map to a ...
6 years, 4 months ago (2014-08-13 15:48:01 UTC) #1
tdanderson
Hi Tim, I found this collecting dust. Do you think we should make this change?
6 years ago (2014-12-11 17:49:49 UTC) #3
tdresser
On 2014/12/11 17:49:49, tdanderson wrote: > Hi Tim, I found this collecting dust. Do you ...
6 years ago (2014-12-11 18:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/466323004/40001
6 years ago (2014-12-11 21:00:31 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 23:08:58 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e59a6e0f1513a92ceaf4725171cee420214b2c3b
Cr-Commit-Position: refs/heads/master@{#307986}

Powered by Google App Engine
This is Rietveld 408576698