Source/core/animation/AnimationNodeTiming.h - Issue 466323002: IDL: Use Nullable for union type return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimationNodeTiming.h

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/AnimationNodeTiming.h

diff --git a/Source/core/animation/AnimationNodeTiming.h b/Source/core/animation/AnimationNodeTiming.h

index ec3474472b608e957de9f5642df90d3945a5a42c..9ef0f1335e1ee8933cc1c2014a11e03dc1ca86c3 100644

--- a/Source/core/animation/AnimationNodeTiming.h

+++ b/Source/core/animation/AnimationNodeTiming.h

@@ -5,6 +5,7 @@

#ifndef AnimationNodeTiming_h

#define AnimationNodeTiming_h

+#include "bindings/core/v8/Nullable.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/animation/AnimationNode.h"

#include "wtf/RefCounted.h"

@@ -20,7 +21,7 @@ public:

String fill();

double iterationStart();

double iterations();

- void getDuration(String propertyName, bool& element0Enabled, double& element0, bool& element1Enabled, String& element1);

+ void getDuration(String propertyName, Nullable<double>& element0, String& element1);

double playbackRate();

String direction();

String easing();