Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 5d599ab428dddef3676a84cbb6d983f34792fac0..ce2e63a89da0fe4819236413c0e1a9bd4f1230a4 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -211,7 +211,9 @@ def cpp_type_initializer(idl_type):
def cpp_type_union(idl_type, extended_attributes=None, raw_type=False):
- return (member_type.cpp_type for member_type in idl_type.member_types)
+ # FIXME: Need to revisit the design of union support.
+ # http://crbug.com/240176
+ return None
def cpp_type_initializer_union(idl_type):
@@ -718,19 +720,10 @@ def v8_set_return_value(idl_type, cpp_value, extended_attributes=None, script_wr
def v8_set_return_value_union(idl_type, cpp_value, extended_attributes=None, script_wrappable='', release=False, for_main_world=False):
- """
- release: can be either False (False for all member types) or
- a sequence (list or tuple) of booleans (if specified individually).
- """
+ # FIXME: Need to revisit the design of union support.
+ # http://crbug.com/240176
+ return None
- return [
- member_type.v8_set_return_value(cpp_value + str(i),
- extended_attributes,
- script_wrappable,
- release and release[i],
- for_main_world)
- for i, member_type in
- enumerate(idl_type.member_types)]
IdlTypeBase.v8_set_return_value = v8_set_return_value
IdlUnionType.v8_set_return_value = v8_set_return_value_union
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698