Source/core/html/HTMLOptionsCollection.h - Issue 466323002: IDL: Use Nullable for union type return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.h

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionsCollection.h

diff --git a/Source/core/html/HTMLOptionsCollection.h b/Source/core/html/HTMLOptionsCollection.h

index 23c19ed1e4c0a65f03c0922f8313f088de3a4ad7..6ae68f212b035bc99195866e9a05390d0297e279 100644

--- a/Source/core/html/HTMLOptionsCollection.h

+++ b/Source/core/html/HTMLOptionsCollection.h

@@ -24,6 +24,7 @@

#ifndef HTMLOptionsCollection_h

#define HTMLOptionsCollection_h

+#include "bindings/core/v8/Nullable.h"

#include "core/html/HTMLCollection.h"

namespace blink {

@@ -44,7 +45,7 @@ public:

void setSelectedIndex(int);

void setLength(unsigned, ExceptionState&);

- void namedGetter(const AtomicString& name, bool&, RefPtrWillBeRawPtr<NodeList>&, bool&, RefPtrWillBeRawPtr<Element>&);

+ void namedGetter(const AtomicString& name, Nullable<RefPtrWillBeRawPtr<NodeList> >&, Nullable<RefPtrWillBeRawPtr<Element> >&);

bool anonymousIndexedSetter(unsigned, PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&);

private: