Source/bindings/scripts/v8_interface.py - Issue 466323002: IDL: Use Nullable for union type return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 6f3b7fe078f37e421b5b6c2823fd571b381de154..772023721da561cfe621a70fda7ebeb47f1f4d06 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -934,7 +934,7 @@ def interface_length(interface, constructors):

def property_getter(getter, cpp_arguments):

def is_null_expression(idl_type):

if idl_type.is_union_type:

- return ' && '.join('!result%sEnabled' % i

+ return ' && '.join('result%s.isNull()' % i

for i, _ in enumerate(idl_type.member_types))

if idl_type.name == 'String':

return 'result.isNull()'