Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: Source/core/html/HTMLAllCollection.cpp

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLAllCollection.cpp
diff --git a/Source/core/html/HTMLAllCollection.cpp b/Source/core/html/HTMLAllCollection.cpp
index d434abdfbf4df45aede64dc6064fbc12664db587..1e0765c9fdcd847c438cd42623126976ee2b674d 100644
--- a/Source/core/html/HTMLAllCollection.cpp
+++ b/Source/core/html/HTMLAllCollection.cpp
@@ -66,7 +66,7 @@ Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne
return 0;
}
-void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtrWillBeRawPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtrWillBeRawPtr<Element>& returnValue1)
+void HTMLAllCollection::namedGetter(const AtomicString& name, Nullable<RefPtrWillBeRawPtr<NodeList> >& returnValue0, Nullable<RefPtrWillBeRawPtr<Element> >& returnValue1)
{
WillBeHeapVector<RefPtrWillBeMember<Element> > namedItems;
this->namedItems(name, namedItems);
@@ -75,15 +75,13 @@ void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0
return;
if (namedItems.size() == 1) {
- returnValue1Enabled = true;
- returnValue1 = namedItems.at(0);
+ returnValue1.set(namedItems.at(0));
return;
}
// FIXME: HTML5 specification says this should be a HTMLCollection.
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
- returnValue0Enabled = true;
- returnValue0 = StaticElementList::adopt(namedItems);
+ returnValue0.set(StaticElementList::adopt(namedItems));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698