IDL: Use Nullable for union type return value

Source/core/animation/AnimationTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/Animation.h"
 
 #include "bindings/core/v8/Dictionary.h"
+#include "bindings/core/v8/Nullable.h"
 #include "core/animation/AnimationClock.h"
 #include "core/animation/AnimationHelpers.h"
 #include "core/animation/AnimationNodeTiming.h"
 #include "core/animation/AnimationTestHelper.h"
 #include "core/animation/AnimationTimeline.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/Timing.h"
 #include "core/dom/Document.h"
 #include <gtest/gtest.h>
 #include <v8.h>
@@ skipping 224 matching lines @@
 {
     Vector<Dictionary, 0> jsKeyframes;
 
     v8::Handle<v8::Object> timingInputWithDuration = v8::Object::New(m_isolate);
     setV8ObjectPropertyAsNumber(timingInputWithDuration, "duration", 2.5);
     Dictionary timingInputDictionaryWithDuration = Dictionary(v8::Handle<v8::Value>::Cast(timingInputWithDuration), m_isolate);
 
     RefPtrWillBeRawPtr<Animation> animationWithDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryWithDuration, exceptionState);
 
     RefPtrWillBeRawPtr<AnimationNodeTiming> specifiedWithDuration = animationWithDuration->timing();
-    bool isNumber = false;
-    double numberDuration = std::numeric_limits<double>::quiet_NaN();
-    bool isString = false;
-    String stringDuration = "";
-    specifiedWithDuration->getDuration("duration", isNumber, numberDuration, isString, stringDuration);
-    EXPECT_TRUE(isNumber);
-    EXPECT_EQ(2.5, numberDuration);
-    EXPECT_FALSE(isString);
-    EXPECT_EQ("", stringDuration);
+    Nullable<double> numberDuration;
+    String stringDuration;
+    specifiedWithDuration->getDuration("duration", numberDuration, stringDuration);
+    EXPECT_FALSE(numberDuration.isNull());
+    EXPECT_EQ(2.5, numberDuration.get());
+    EXPECT_TRUE(stringDuration.isNull());
 
 
     v8::Handle<v8::Object> timingInputNoDuration = v8::Object::New(m_isolate);
     Dictionary timingInputDictionaryNoDuration = Dictionary(v8::Handle<v8::Value>::Cast(timingInputNoDuration), m_isolate);
 
     RefPtrWillBeRawPtr<Animation> animationNoDuration = createAnimation(element.get(), jsKeyframes, timingInputDictionaryNoDuration, exceptionState);
 
     RefPtrWillBeRawPtr<AnimationNodeTiming> specifiedNoDuration = animationNoDuration->timing();
-    isNumber = false;
-    numberDuration = std::numeric_limits<double>::quiet_NaN();
-    isString = false;
-    stringDuration = "";
-    specifiedNoDuration->getDuration("duration", isNumber, numberDuration, isString, stringDuration);
-    EXPECT_FALSE(isNumber);
-    EXPECT_TRUE(std::isnan(numberDuration));
-    EXPECT_TRUE(isString);
-    EXPECT_EQ("auto", stringDuration);
+    Nullable<double> numberDuration2;
+    String stringDuration2;
+    specifiedNoDuration->getDuration("duration", numberDuration2, stringDuration2);
+    EXPECT_TRUE(numberDuration2.isNull());
+    EXPECT_FALSE(stringDuration2.isNull());
+    EXPECT_EQ("auto", stringDuration2);
 }
 
 TEST_F(AnimationAnimationV8Test, SpecifiedSetters)
 {
     Vector<Dictionary, 0> jsKeyframes;
     v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
     Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cast(timingInput), m_isolate);
     RefPtrWillBeRawPtr<Animation> animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary, exceptionState);
 
     RefPtrWillBeRawPtr<AnimationNodeTiming> specified = animation->timing();
@@ skipping 33 matching lines @@
 
 TEST_F(AnimationAnimationV8Test, SetSpecifiedDuration)
 {
     Vector<Dictionary, 0> jsKeyframes;
     v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
     Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cast(timingInput), m_isolate);
     RefPtrWillBeRawPtr<Animation> animation = createAnimation(element.get(), jsKeyframes, timingInputDictionary, exceptionState);
 
     RefPtrWillBeRawPtr<AnimationNodeTiming> specified = animation->timing();
 
-    bool isNumber = false;
-    double numberDuration = std::numeric_limits<double>::quiet_NaN();
-    bool isString = false;
-    String stringDuration = "";
-    specified->getDuration("duration", isNumber, numberDuration, isString, stringDuration);
-    EXPECT_FALSE(isNumber);
-    EXPECT_TRUE(std::isnan(numberDuration));
-    EXPECT_TRUE(isString);
+    Nullable<double> numberDuration;
+    String stringDuration;
+    specified->getDuration("duration", numberDuration, stringDuration);
+    EXPECT_TRUE(numberDuration.isNull());
+    EXPECT_FALSE(stringDuration.isNull());
     EXPECT_EQ("auto", stringDuration);
 
     specified->setDuration("duration", 2.5);
-    isNumber = false;
-    numberDuration = std::numeric_limits<double>::quiet_NaN();
-    isString = false;
-    stringDuration = "";
-    specified->getDuration("duration", isNumber, numberDuration, isString, stringDuration);
-    EXPECT_TRUE(isNumber);
-    EXPECT_EQ(2.5, numberDuration);
-    EXPECT_FALSE(isString);
-    EXPECT_EQ("", stringDuration);
+    Nullable<double> numberDuration2;
+    String stringDuration2;
+    specified->getDuration("duration", numberDuration2, stringDuration2);
+    EXPECT_FALSE(numberDuration2.isNull());
+    EXPECT_EQ(2.5, numberDuration2.get());
+    EXPECT_TRUE(stringDuration2.isNull());
 }
 
 TEST_F(AnimationAnimationTest, TimeToEffectChange)
 {
     Timing timing;
     timing.iterationDuration = 100;
     timing.startDelay = 100;
     timing.endDelay = 100;
     timing.fillMode = Timing::FillModeNone;
     RefPtrWillBeRawPtr<Animation> animation = Animation::create(0, nullptr, timing);
@@ skipping 96 matching lines @@
     EXPECT_EQ(element.get(), animation->target());
     document->timeline().play(animation.get());
     document.clear();
     element.clear();
 #if !ENABLE(OILPAN)
     EXPECT_EQ(0, animation->target());
 #endif
 }
 
 } // namespace blink