Source/bindings/tests/idls/TestTypedefs.idl - Issue 466323002: IDL: Use Nullable for union type return value

Side by Side Diff: Source/bindings/tests/idls/TestTypedefs.idl

Issue 466323002: IDL: Use Nullable for union type return value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestSpecialOperations.cpp » ('j') | Source/bindings/tests/results/V8TestSpecialOperations.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 23 matching lines...) Expand all Loading...
34	34

35 typedef float Float;	35 typedef float Float;

36 typedef unsigned long long ULongLong;	36 typedef unsigned long long ULongLong;

37 typedef TestInterfaceEmpty TestInterfaceEmptyType;	37 typedef TestInterfaceEmpty TestInterfaceEmptyType;

38 typedef long[] ArrayOfLongs;	38 typedef long[] ArrayOfLongs;

39 typedef DOMString String;	39 typedef DOMString String;

40 typedef DOMString[] ArrayOfStrings;	40 typedef DOMString[] ArrayOfStrings;

41 typedef TestCallbackInterface TestCallbackInterfaceType;	41 typedef TestCallbackInterface TestCallbackInterfaceType;

42 typedef TestInterfaceConstructor T;	42 typedef TestInterfaceConstructor T;

43 typedef (TestInterface or TestInterfaceEmpty) TestInterfaceOrTestInterfaceEmpty;	43 typedef (TestInterface or TestInterfaceEmpty) TestInterfaceOrTestInterfaceEmpty;

	44 typedef (DOMString or double) DOMStringOrDouble;
	haraken 2014/08/15 07:34:15 Consider adding more test cases about union types Consider adding more test cases about union types in a follow-up CL. The current test coverage for union types is low. bashi 2014/08/15 10:14:07 Yes. We should add more test cases. I'll add more Show quoted text On 2014/08/15 07:34:15, haraken wrote: > > Consider adding more test cases about union types in a follow-up CL. The current > test coverage for union types is low. Yes. We should add more test cases. I'll add more tests in follow-up CLs.
44	45

45 [	46 [

46 Constructor(String stringArg),	47 Constructor(String stringArg),

47 ] interface TestTypedefs {	48 ] interface TestTypedefs {

48 attribute ULongLong uLongLongAttribute;	49 attribute ULongLong uLongLongAttribute;

49 attribute T tAttribute;	50 attribute T tAttribute;

50	51

51 void voidMethodArrayOfLongsArg(optional ArrayOfLongs arrayOfLongsArg);	52 void voidMethodArrayOfLongsArg(optional ArrayOfLongs arrayOfLongsArg);

52	53

53 void voidMethodFloatArgStringArg(Float floatArg, String stringArg);	54 void voidMethodFloatArgStringArg(Float floatArg, String stringArg);

54 void voidMethodTestCallbackInterfaceTypeArg(TestCallbackInterfaceType testCa llbackInterfaceTypeArg);	55 void voidMethodTestCallbackInterfaceTypeArg(TestCallbackInterfaceType testCa llbackInterfaceTypeArg);

55	56

56 ULongLong uLongLongMethodTestInterfaceEmptyTypeSequenceArg(sequence<TestInte rfaceEmptyType> testInterfaceEmptyTypeSequenceArg);	57 ULongLong uLongLongMethodTestInterfaceEmptyTypeSequenceArg(sequence<TestInte rfaceEmptyType> testInterfaceEmptyTypeSequenceArg);

57 TestInterfaceOrTestInterfaceEmpty testInterfaceOrTestInterfaceEmptyMethod();	58 TestInterfaceOrTestInterfaceEmpty testInterfaceOrTestInterfaceEmptyMethod();

	59 DOMStringOrDouble domStringOrDoubleMethod();

58	60

59 ArrayOfStrings arrayOfStringsMethodArrayOfStringsArg(ArrayOfStrings arrayOfS tringsArg);	61 ArrayOfStrings arrayOfStringsMethodArrayOfStringsArg(ArrayOfStrings arrayOfS tringsArg);

60 String[] stringArrayMethodStringArrayArg(String[] stringArrayArg);	62 String[] stringArrayMethodStringArrayArg(String[] stringArrayArg);

61 };	63 };

OLD	NEW