Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466293002: Hardcode applist icon dimension and shadows. (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Hardcode applist icon dimension and shadows. These are currently data members, but they are always the same. This simplifies upcoming app list refactoring. BUG=403647 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289520

Patch Set 1 #

Patch Set 2 : stray line #

Patch Set 3 : whoops - left in a function dec #

Total comments: 2

Patch Set 4 : s/kPreferredIconDimension/kGridIconDimension/g, move header #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -54 lines) Patch
M ui/app_list/app_list_constants.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_constants.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_folder_item.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/test/app_list_test_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_folder_view.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_item_view.h View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 2 3 7 chunks +19 lines, -25 lines 2 comments Download
M ui/app_list/views/apps_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 2 3 5 chunks +4 lines, -8 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M ui/app_list/views/top_icon_animation_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Hi Ben.. an easy one to start
6 years, 4 months ago (2014-08-13 07:49:59 UTC) #1
benwells
https://codereview.chromium.org/466293002/diff/40001/ui/app_list/views/app_list_item_view.cc File ui/app_list/views/app_list_item_view.cc (right): https://codereview.chromium.org/466293002/diff/40001/ui/app_list/views/app_list_item_view.cc#newcode309 ui/app_list/views/app_list_item_view.cc:309: y + kPreferredIconDimension + kIconTitleSpacing, i think this name ...
6 years, 4 months ago (2014-08-13 22:47:07 UTC) #2
tapted
also realised I could move a header to .cc. PTAL https://codereview.chromium.org/466293002/diff/40001/ui/app_list/views/app_list_item_view.cc File ui/app_list/views/app_list_item_view.cc (right): https://codereview.chromium.org/466293002/diff/40001/ui/app_list/views/app_list_item_view.cc#newcode309 ...
6 years, 4 months ago (2014-08-14 00:54:34 UTC) #3
benwells
lgtm https://codereview.chromium.org/466293002/diff/60001/ui/app_list/views/app_list_item_view.cc File ui/app_list/views/app_list_item_view.cc (right): https://codereview.chromium.org/466293002/diff/60001/ui/app_list/views/app_list_item_view.cc#newcode65 ui/app_list/views/app_list_item_view.cc:65: CR_DEFINE_STATIC_LOCAL( This seems yucky, but whatevs. I guess ...
6 years, 4 months ago (2014-08-14 01:55:35 UTC) #4
tapted
Thanks Ben! (Added a tracker BUG= since I want to group these CLs someplace) https://codereview.chromium.org/466293002/diff/60001/ui/app_list/views/app_list_item_view.cc ...
6 years, 4 months ago (2014-08-14 04:10:56 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-14 04:40:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/466293002/60001
6 years, 4 months ago (2014-08-14 04:42:46 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 11:02:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 289520

Powered by Google App Engine
This is Rietveld 408576698