Issue 466283003: Use LookupIterator for CompileLoadInterceptor and delete Object::Lookup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466283003: Use LookupIterator for CompileLoadInterceptor and delete Object::Lookup (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Use LookupIterator for CompileLoadInterceptor and delete Object::Lookup BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23168

Patch Set 2 : Add ports #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+332 lines, -380 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+62 lines, -77 lines	0 comments	Download
M	src/arm64/stub-cache-arm64.cc	View	1	1 chunk	+62 lines, -76 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	1 chunk	+72 lines, -87 lines	1 comment	Download
M	src/ic.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/lookup.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	src/stub-cache.h	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+44 lines, -25 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	1 chunk	+66 lines, -80 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

On 2014/08/13 13:49:19, Toon Verwaest wrote: > PTAL DBC: yay!

6 years, 4 months ago (2014-08-13 14:04:00 UTC) #2

Jakob Kummerow

LGTM with a comment that applies to all platforms. https://codereview.chromium.org/466283003/diff/20001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/466283003/diff/20001/src/ia32/stub-cache-ia32.cc#newcode796 src/ia32/stub-cache-ia32.cc:796: ...

6 years, 4 months ago (2014-08-18 14:54:03 UTC) #3

Toon Verwaest

6 years, 4 months ago (2014-08-18 15:03:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23168 (tree was closed).

Expand Messages | Collapse Messages

Issue 466283003: Use LookupIterator for CompileLoadInterceptor and delete Object::Lookup (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add ports #

Messages