Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 466283002: Rename parameter providedleastNumMandatoryParams => provided (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename parameter providedleastNumMandatoryParams => provided The name is probably a copy/paste typo originally; the expression used for the |expected| parameter's value in code_generator_v8.pm originally was $leastNumMandatoryParams, and this identifier somehow ended up concatenated to the |provided| parameter's name on the C++ side. Since then, the strange name has spread a bit, and had been "fixed" into |providedLeastNumMandatoryParams| in some places along the way. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/core/v8/ExceptionMessages.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL Just a bit of simple naming cleanup.
6 years, 4 months ago (2014-08-13 06:19:01 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-13 07:06:18 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-13 07:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/466283002/1
6 years, 4 months ago (2014-08-13 08:00:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 08:04:07 UTC) #5
Message was sent while issue was closed.
Change committed as 180154

Powered by Google App Engine
This is Rietveld 408576698