Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 466273002: Remove OpenWindow from the WindowManager interface. (Closed)

Created:
6 years, 4 months ago by Ben Goodger (Google)
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove OpenWindow from WindowManager API. This time much simpler than before. Instead the test just waits for the embed to happen (since it's all URL fakery anyway) and returns the id of the root view. Also adds a simple window manager shell implementation for tests, needed to keep the window manager tests from crashing. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289467

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : Fix shutdown races. #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -116 lines) Patch
M mojo/public/cpp/application/lib/service_provider_impl.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/lib/weak_service_provider.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M mojo/public/cpp/application/lib/weak_service_provider.cc View 1 2 3 1 chunk +11 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/services/window_manager/main.cc View 1 2 3 4 2 chunks +59 lines, -1 line 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 3 chunks +11 lines, -37 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 2 3 chunks +6 lines, -22 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 chunk +3 lines, -7 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.cc View 1 chunk +6 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Goodger (Google)
6 years, 4 months ago (2014-08-13 05:33:59 UTC) #1
sky
Nice indeed, LGTM https://codereview.chromium.org/466273002/diff/1/mojo/services/window_manager/main.cc File mojo/services/window_manager/main.cc (right): https://codereview.chromium.org/466273002/diff/1/mojo/services/window_manager/main.cc#newcode25 mojo/services/window_manager/main.cc:25: view_manager_(NULL) {} root_(NULL) too.
6 years, 4 months ago (2014-08-13 14:41:53 UTC) #2
Ben Goodger (Google)
Plz take another look. Had to make some additional changes to fix some uafs & ...
6 years, 4 months ago (2014-08-13 21:21:21 UTC) #3
sky
LGTM https://codereview.chromium.org/466273002/diff/60001/mojo/services/window_manager/main.cc File mojo/services/window_manager/main.cc (right): https://codereview.chromium.org/466273002/diff/60001/mojo/services/window_manager/main.cc#newcode25 mojo/services/window_manager/main.cc:25: view_manager_(NULL) {} Add root_(NULL)
6 years, 4 months ago (2014-08-13 21:35:47 UTC) #4
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 4 months ago (2014-08-13 22:18:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/466273002/80001
6 years, 4 months ago (2014-08-13 22:20:47 UTC) #6
Ben Goodger (Google)
6 years, 4 months ago (2014-08-14 05:19:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as 289467 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698