Source/bindings/dart/DartJsInterop.cpp - Issue 466243002: Support merged Dart-JS callstacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/DartJsInterop.cpp

Issue 466243002: Support merged Dart-JS callstacks (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/dart/DartJsInterop.cpp

diff --git a/Source/bindings/dart/DartJsInterop.cpp b/Source/bindings/dart/DartJsInterop.cpp

index 36881d2a1263b6c774227134cec32a619cede11b..335d162b0548fbe48e8aee4aaed7865e8d25de64 100644

--- a/Source/bindings/dart/DartJsInterop.cpp

+++ b/Source/bindings/dart/DartJsInterop.cpp

@@ -77,6 +77,9 @@ static void functionInvocationCallback(const v8::FunctionCallbackInfo<v8::Value>

DartScopes scopes(args.Holder());

Dart_Handle handle = scopes.handle;

DartDOMData* domData = DartDOMData::current();

+ // We need to call V8Scope to properly track the stack depth and timestamp

+ // for the transition between V8 and Dart.

+ V8Scope v8scope(domData);

ASSERT(domData);

ASSERT(DartUtilities::isFunction(domData, handle));