Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: LayoutTests/dart/inspector/merged-callstack.html

Issue 466243002: Support merged Dart-JS callstacks (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/dart/inspector/merged-callstack.dart ('k') | LayoutTests/dart/inspector/merged-callstack.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/dart/inspector/merged-callstack.html
diff --git a/LayoutTests/dart/inspector/scope-variables.html b/LayoutTests/dart/inspector/merged-callstack.html
similarity index 66%
copy from LayoutTests/dart/inspector/scope-variables.html
copy to LayoutTests/dart/inspector/merged-callstack.html
index 03bfbd18fae8e29bbc43f917324b9825855cc320..283ddfe8bd53534a8e15d6da53a409f803817a21 100644
--- a/LayoutTests/dart/inspector/scope-variables.html
+++ b/LayoutTests/dart/inspector/merged-callstack.html
@@ -2,7 +2,8 @@
<script src="../../http/tests/inspector/inspector-test.js"></script>
<script src="../../http/tests/inspector/debugger-test.js"></script>
-<script type="application/dart" src="scope-variables.dart"></script>
+<script type="application/dart" src="merged-callstack.dart"></script>
+<script src="merged-callstack.js"></script>
<script>
@@ -21,11 +22,11 @@ function test()
InspectorTest.runDebuggerTestSuite([
function testScopeChain(next)
{
- InspectorTest.showScriptSource('scope-variables.dart', didShowScriptSource);
+ InspectorTest.showScriptSource('merged-callstack.dart', didShowScriptSource);
function didShowScriptSource(sourceFrame)
{
- setBreakpointAndWaitUntilPaused(sourceFrame, 23, didPauseInDart);
+ setBreakpointAndWaitUntilPaused(sourceFrame, 25, didPauseInDart);
InspectorTest.runTestFunction();
}
@@ -39,32 +40,6 @@ function test()
function didExpandScopeChainSections()
{
dumpScopeChainContents();
- var sections = WebInspector.inspectorView.currentPanel().sidebarPanes.scopechain._sections;
- for (var s = 0; s < sections.length; s++) {
- var section = sections[s];
-
- var properties = section.propertiesForTest;
- for (var i = 0; i < properties.length; ++i) {
- if (properties[i].name == 'a1') {
- var objectId = properties[i].value._objectId;
- RuntimeAgent.callFunctionOn(objectId, "(){return this.toString();}", [], undefined, didCallFunctionOn);
- RuntimeAgent.callFunctionOn(objectId, "function(){return this.toString();}", [], undefined, didCallInvalidFunctionOn);
- break;
- }
- }
- if (!section.expanded)
- InspectorTest.addResult(" <section collapsed>");
- }
- }
-
- function didCallFunctionOn(error, result, wasThrown)
- {
- InspectorTest.addResult("Inspected value toString(): " + result.value);
- InspectorTest.resumeExecution(next);
- }
- function didCallInvalidFunctionOn(error, result, wasThrown)
- {
- InspectorTest.addResult("Result of calling invalid function. value: " + result.value + ". exception thrown: " + wasThrown);
InspectorTest.resumeExecution(next);
}
}
« no previous file with comments | « LayoutTests/dart/inspector/merged-callstack.dart ('k') | LayoutTests/dart/inspector/merged-callstack.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698