Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 466233002: [Telemetry] Improve unittest cycle time and fix testIFrame. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Improve unittest cycle time and fix testIFrame. Starting chrome to about:blank instead of the NTP improves telemetry_unittests cycle time by ~14% (172s -> 148s) on my MBP. This required a couple of test updates: 1. It made testIFrame fail deterministically which exposed the source of flake. The context_id isn't the current index, it is just a monotonically increasing ID. So it depends on the number of contexts used previously. 2. It made the GPU memory test measure a larger delta (presumably due to the simpler previous page). BUG=394454, 388256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289423

Patch Set 1 #

Patch Set 2 : update gpu memory expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M content/test/gpu/gpu_tests/memory.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py View 3 chunks +17 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
tonyg
6 years, 4 months ago (2014-08-13 03:20:09 UTC) #1
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 4 months ago (2014-08-13 03:49:55 UTC) #2
dtu
lgtm
6 years, 4 months ago (2014-08-13 03:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/466233002/1
6 years, 4 months ago (2014-08-13 03:51:40 UTC) #4
achuithb
LGTM. Thanks for fixing this!
6 years, 4 months ago (2014-08-13 07:57:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-13 08:02:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 08:23:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/34830)
6 years, 4 months ago (2014-08-13 08:23:04 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-13 13:34:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/466233002/1
6 years, 4 months ago (2014-08-13 13:36:18 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-13 13:56:51 UTC) #11
tonyg
Hi zmo, kbr, This patch made the retina gpu memory test fail with: Failure: Memory ...
6 years, 4 months ago (2014-08-13 14:10:18 UTC) #12
Zhenyao Mo
LGTM I am wondering instead of changing the WIGGLE_ROOM, maybe we should adjust the base ...
6 years, 4 months ago (2014-08-13 19:42:55 UTC) #13
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-13 19:43:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/466233002/20001
6 years, 4 months ago (2014-08-13 19:45:40 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 00:27:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289423

Powered by Google App Engine
This is Rietveld 408576698