Move settings setup for PDF and cloud print into single location in PrintingContext

printing/printing_context.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printing_context.h"
 
 #include "base/logging.h"
 #include "base/values.h"
 #include "printing/page_setup.h"
 #include "printing/page_size_margins.h"
 #include "printing/print_settings_initializer.h"
+#include "printing/units.h"
 
 namespace printing {
 
+namespace {
+const float kCloudPrintMarginInch = 0.25;
+}
+
 PrintingContext::PrintingContext(const std::string& app_locale)
     : dialog_box_dismissed_(false),
       in_print_job_(false),
       abort_printing_(false),
       app_locale_(app_locale) {
 }
 
 PrintingContext::~PrintingContext() {
 }
 
@@ skipping 15 matching lines @@
 PrintingContext::Result PrintingContext::OnError() {
   ResetSettings();
   return abort_printing_ ? CANCEL : FAILED;
 }
 
 PrintingContext::Result PrintingContext::UpdatePrintSettings(
     const base::DictionaryValue& job_settings,
     const PageRanges& ranges) {
   ResetSettings();
 
-  if (settings_.dpi() == 0)
-    UseDefaultSettings();
-
   if (!PrintSettingsInitializer::InitSettings(job_settings, ranges,
                                               &settings_)) {
     NOTREACHED();
     return OnError();
   }
 
   bool print_to_pdf = false;
   bool is_cloud_dialog = false;
 
   if (!job_settings.GetBoolean(kSettingPrintToPDF, &print_to_pdf) ||
       !job_settings.GetBoolean(kSettingCloudPrintDialog, &is_cloud_dialog)) {
     NOTREACHED();
     return OnError();
   }
 
   bool print_to_cloud = job_settings.HasKey(kSettingCloudPrintId);
   bool open_in_external_preview =
       job_settings.HasKey(kSettingOpenPDFInPreview);
 
-  return UpdatePrinterSettings(
-      print_to_pdf || is_cloud_dialog || print_to_cloud,
-      open_in_external_preview);
+  if (!open_in_external_preview &&
+      (print_to_pdf || print_to_cloud || is_cloud_dialog)) {
+    settings_.set_dpi(kDefaultPdfDpi);
+    // Cloud print should get size and rect from capabilities received from
+    // server.
+    gfx::Size paper_size(GetPdfPaperSizeDeviceUnits());
+    gfx::Rect paper_rect(0, 0, paper_size.width(), paper_size.height());
+    if (print_to_cloud) {
+      paper_rect.Inset(
+          kCloudPrintMarginInch * settings_.device_units_per_inch(),
+          kCloudPrintMarginInch * settings_.device_units_per_inch());
+    }
+    settings_.SetPrinterPrintableArea(paper_size, paper_rect, true);
+    return OK;
+  }
+
+  return UpdatePrinterSettings(open_in_external_preview);
 }
 
 }  // namespace printing