Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 466223008: Adds skia/config/SkUserConfig.h to skia_library.gypi (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Stephen White
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Adds skia/config/SkUserConfig.h to skia_library.gypi BUG=401542 TEST=none R=senorblanco@chromium.org Committed: https://crrev.com/5d73fab57c504e3c0ad4c63e92fa7c0262abe9e4 Cr-Commit-Position: refs/heads/master@{#291787}

Patch Set 1 #

Patch Set 2 : update gn files #

Total comments: 1

Patch Set 3 : skia_chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M skia/skia_chrome.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 4 months ago (2014-08-25 19:54:13 UTC) #1
Stephen White
LGTM with nit fixed, or line moved. https://codereview.chromium.org/466223008/diff/20001/skia/skia_library.gypi File skia/skia_library.gypi (right): https://codereview.chromium.org/466223008/diff/20001/skia/skia_library.gypi#newcode153 skia/skia_library.gypi:153: 'config/SkUserConfig.h', Nit: ...
6 years, 4 months ago (2014-08-25 20:45:00 UTC) #2
sky
skia_chrome looks like the better place. Added there, thanks!
6 years, 4 months ago (2014-08-25 21:31:01 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-25 21:31:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/466223008/40001
6 years, 4 months ago (2014-08-25 21:33:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 22:44:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (40001) as fc62313162a2a115922f75a12947ae06fe612b9d
6 years, 4 months ago (2014-08-25 23:38:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:32 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d73fab57c504e3c0ad4c63e92fa7c0262abe9e4
Cr-Commit-Position: refs/heads/master@{#291787}

Powered by Google App Engine
This is Rietveld 408576698