Issue 466223004: Set correct DOM key code string for functional keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466223004: Set correct DOM key code string for functional keys. (Closed)

Created:
6 years, 4 months ago by Shu Chen

Modified:
6 years, 4 months ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, bshe

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Set correct DOM key code string for functional keys. BUG=402935 TEST=Verified on Pixel. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289565

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -6 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/base/ime/chromeos/ime_keymap.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/ime/chromeos/ime_keymap.cc	View	3 chunks	+22 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/466223004/1

6 years, 4 months ago (2014-08-14 00:37:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 289565

Expand Messages | Collapse Messages