Tools/Scripts/webkitpy/layout_tests/port/browser_test.py - Issue 466223002: Increase timeout for Mac when running print preview tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

Issue 466223002: Increase timeout for Mac when running print preview tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified Mac unittest to reflect changes to the timeout on mac. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py b/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

index 5d5dfd098fa849a1257b19f0116861a4cdc63f04..3f7845e7d4b13cb3bc204d0bfe701cb2d48db408 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

@@ -80,6 +80,13 @@ class BrowserTestMacPort(BrowserTestPortOverrides, mac.MacPort):

def _path_to_driver(self, configuration=None):

return self._build_path_with_configuration(configuration, self.driver_name())

+ def default_timeout_ms(self):

+ timeout_ms = 20 * 1000

+ if self.get_option('configuration') == 'Debug': # pylint: disable=E1101

+ # Debug is usually 2x-3x slower than Release.

+ return 3 * timeout_ms

+ return timeout_ms

class BrowserTestWinPort(BrowserTestPortOverrides, win.WinPort):

def default_timeout_ms(self):

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py » ('j') | no next file with comments »