Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py - Issue 466223002: Increase timeout for Mac when running print preview tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

Issue 466223002: Increase timeout for Mac when running print preview tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified Mac unittest to reflect changes to the timeout on mac. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/browser_test.py ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (C) 2014 Google Inc. All rights reserved.	1 # Copyright (C) 2014 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 93 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
104 def test_driver_path(self):	104 def test_driver_path(self):

105 test_port = self.make_port(options=MockOptions(driver_name='browser_test s'))	105 test_port = self.make_port(options=MockOptions(driver_name='browser_test s'))

106 self.assertFalse('.app/Contents/MacOS' in test_port._path_to_driver())	106 self.assertFalse('.app/Contents/MacOS' in test_port._path_to_driver())

107	107

108 def test_check_sys_deps(self):	108 def test_check_sys_deps(self):

109 port = self.make_port()	109 port = self.make_port()

110 port._executive = MockExecutive2(exit_code=0)	110 port._executive = MockExecutive2(exit_code=0)

111 self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results .OK_EXIT_STATUS)	111 self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results .OK_EXIT_STATUS)

112	112

113 def test_default_timeout_ms(self):	113 def test_default_timeout_ms(self):

114 self.assertEqual(self.make_port(options=MockOptions(configuration='Relea se')).default_timeout_ms(), 10000)	114 self.assertEqual(self.make_port(options=MockOptions(configuration='Relea se')).default_timeout_ms(), 20000)

115 self.assertEqual(self.make_port(options=MockOptions(configuration='Debug ')).default_timeout_ms(), 30000)	115 self.assertEqual(self.make_port(options=MockOptions(configuration='Debug ')).default_timeout_ms(), 60000)

OLD	NEW