Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466203005: Fix regression introduced in r289434 - I missed the test_type. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
tonyg
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Fix regression introduced in r289434 - I missed the test_type. We need to specify the '--test-type' field in the telemetry* unittests, and I missed that from the recipe. TBR=tonyg@chromium.org BUG=323212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/buildnumber_zero.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Committed patchset #1 manually as 289446 (presubmit successful).
6 years, 4 months ago (2014-08-14 02:26:25 UTC) #1
Paweł Hajdan Jr.
6 years, 4 months ago (2014-08-14 08:18:02 UTC) #2
Message was sent while issue was closed. 
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/476653002/ by phajdan.jr@chromium.org.

The reason for reverting is: Reverting telemetry-related changes because of
breakages like
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/buil...
. Please watch the waterfall after applying the change..

Powered by Google App Engine
This is Rietveld 408576698