Issue 466203004: Revert 289404 "Blink roll 180116:180191"

On 2014/08/14 00:15:29, michaeln wrote:
> Committed patchset #1 manually as r289420 (tree was closed).

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

many occurrences of the following...

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x4d2bcb in __interceptor_malloc
(/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/content_browsertests+0x4d2bcb)
    #1 0x37d93ea in partitionAllocGenericFlags
third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20
    #2 0x37d93ea in partitionAllocGeneric
third_party/WebKit/Source/wtf/PartitionAlloc.h:554
    #3 0x37d93ea in WTF::fastMalloc(unsigned long)
third_party/WebKit/Source/wtf/FastMalloc.cpp:74
    #4 0x660407f in operator new
third_party/WebKit/Source/wtf/RefCounted.h:166:5
    #5 0x660407f in blink::ScriptState::create(v8::Handle\u003Cv8::Context>,
WTF::PassRefPtr\u003Cblink::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp:16
    #6 0x6680c3b in blink::WindowProxy::createContext()
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:266:21
    #7 0x667fae0 in blink::WindowProxy::initialize()
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:193:5
    #8 0x667f804 in blink::WindowProxy::initializeIfNeeded()
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:179:19
    #9 0x65dea4e in
blink::ScriptController::windowProxy(blink::DOMWrapperWorld&)
third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:236:49
    #10 0x6647878 in blink::toV8Context(blink::LocalFrame*,
blink::DOMWrapperWorld&)
third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:735:38
    #11 0x843521 in content::(anonymous
namespace)::GinBrowserTest_GinAndGarbageCollection_Test::TestBody()
content/renderer/gin_browsertest.cc:68:9
    #12 0x14f8a58 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
void> testing/gtest/src/gtest.cc:2418:12
    #13 0x14f8a58 in testing::Test::Run() testing/gtest/src/gtest.cc:2434
    #14 0x14faed9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #15 0x14fbf36 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #16 0x15119d5 in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4591:11
    #17 0x1510fe4 in
HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2418:12
    #18 0x1510fe4 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #19 0x1196d2f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #20 0x1196d2f in base::TestSuite::Run() base/test/test_suite.cc:227
    #21 0xfd3d4a in content::ContentTestLauncherDelegate::RunTestSuite(int,
char**) content/test/content_test_launcher.cc:97:12
    #22 0x11520e7 in content::LaunchTests(content::TestLauncherDelegate*, int,
int, char**) content/public/test/test_launcher.cc:469:12
    #23 0xfd3c08 in main content/test/content_test_launcher.cc:123:10
    #24 0x7f9ace03976c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226

michaeln

I'll resubmit with a change to the lsan/suppressions.txt that correponds with the class name change ...

6 years, 4 months ago (2014-08-14 00:32:39 UTC) #5

michaeln

On 2014/08/14 00:32:39, michaeln wrote: > I'll resubmit with a change to the lsan/suppressions.txt that ...

6 years, 4 months ago (2014-08-14 00:47:49 UTC) #6

adamk

6 years, 4 months ago (2014-08-14 15:55:04 UTC) #7

Message was sent while issue was closed.

On 2014/08/14 at 00:47:49, michaeln wrote:
> On 2014/08/14 00:32:39, michaeln wrote:
> > I'll resubmit with a change to the lsan/suppressions.txt that correponds
with
> > the class name change from V8WindowShell to WindowProxy.
> 
> https://codereview.chromium.org/470793002/

Thanks! Sorry I wasn't around to help out with this (had a doctor's appt).

Expand Messages | Collapse Messages