runtime/vm/object.h - Issue 466183002: Use function names as service IDs, rather than indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 466183002: Use function names as service IDs, rather than indices. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 39179)

+++ runtime/vm/object.h (working copy)

@@ -949,7 +949,7 @@

// Returns true if non-static fields are defined.

bool HasInstanceFields() const;

- // TODO(koda): Avoid VM service indexing into this array; unite w/ hash table.

+ // TODO(koda): Unite w/ hash table.

RawArray* functions() const { return raw_ptr()->functions_; }

void SetFunctions(const Array& value) const;

void AddFunction(const Function& function) const;

« no previous file with comments | « runtime/bin/vmservice/observatory/test/functions_test.dart ('k') | runtime/vm/object.cc » ('j') | runtime/vm/service.cc » ('J')