Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 466183002: Use function names as service IDs, rather than indices. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/observatory/test/functions_test.dart » ('j') | runtime/vm/service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart
===================================================================
--- runtime/bin/vmservice/observatory/lib/src/service/object.dart (revision 39179)
+++ runtime/bin/vmservice/observatory/lib/src/service/object.dart (working copy)
@@ -1370,6 +1370,7 @@
}
}
+// TODO(koda): Sync this with VM.
class FunctionKind {
final String _strValue;
FunctionKind._internal(this._strValue);
@@ -1383,8 +1384,8 @@
case 'kGetterFunction': return kGetterFunction;
case 'kSetterFunction': return kSetterFunction;
case 'kConstructor': return kConstructor;
- case 'kImplicitGetterFunction': return kImplicitGetterFunction;
- case 'kImplicitSetterFunction': return kImplicitSetterFunction;
+ case 'kImplicitGetter': return kImplicitGetterFunction;
+ case 'kImplicitSetter': return kImplicitSetterFunction;
case 'kStaticInitializer': return kStaticInitializer;
case 'kMethodExtractor': return kMethodExtractor;
case 'kNoSuchMethodDispatcher': return kNoSuchMethodDispatcher;
« no previous file with comments | « no previous file | runtime/bin/vmservice/observatory/test/functions_test.dart » ('j') | runtime/vm/service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698