Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 466153006: add --descriptions flag to render_pictures tool (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add --descriptions flag to render_pictures tool Needed because right now, when you look at the full set of SKP results in rebaseline_server, you can't tell which renderMode (or builder) generated each one. BUG=skia:2833 Committed: https://skia.googlesource.com/skia/+/b492c6ff308013eab3398992c10948997e348c45

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M gm/gm_json.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/image_expectations.h View 2 chunks +9 lines, -0 lines 0 comments Download
M tools/image_expectations.cpp View 3 chunks +7 lines, -1 line 0 comments Download
M tools/render_pictures_main.cpp View 3 chunks +11 lines, -4 lines 1 comment Download
M tools/tests/render_pictures_test.py View 10 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Eric (and Stephan), PTAL at patchset 1. https://codereview.chromium.org/466153006/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.chromium.org/466153006/diff/1/tools/render_pictures_main.cpp#newcode29 tools/render_pictures_main.cpp:29: DEFINE_bool(bench_record, false, ...
6 years, 4 months ago (2014-08-14 06:18:01 UTC) #1
borenet
Code LGTM, but I wonder whether it'd be better to have the buildbot scripts do ...
6 years, 4 months ago (2014-08-14 12:06:43 UTC) #2
epoger
On 2014/08/14 12:06:43, borenet wrote: > Code LGTM, but I wonder whether it'd be better ...
6 years, 4 months ago (2014-08-14 14:22:29 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-14 14:22:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/466153006/1
6 years, 4 months ago (2014-08-14 14:23:30 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:32:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as b492c6ff308013eab3398992c10948997e348c45

Powered by Google App Engine
This is Rietveld 408576698