Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 466143005: Fix crash on GestureTap in Node::commonAncestor (Closed)

Created:
6 years, 4 months ago by Rick Byers
Modified:
6 years, 4 months ago
Reviewers:
Zeeshan Qureshi
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Fix crash on GestureTap in Node::commonAncestor When doing a tap, if the synthetic mousedown lands on some node, but changes the DOM such that there's no node at that point afterwards (eg. a frame scrollbar), then we'll pass a null node pointer to commonAncestor and crash. In addition to adding a test for this case (the mousedown case in gesture-tap-frame-scrollbar) I added tests for a number of similar cases (null hit test and removed node) that are already working correctly but could be subject to similar bugs. Also corrected a minor typo in a related test (gesture-tap-click-common-ancestor) - doesn't change behavior, just better reflects the intention of the test (the ancestor node itself should not be hittable). BUG=402338 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180389

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -15 lines) Patch
M LayoutTests/fast/events/touch/gesture/gesture-tap-click-common-ancestor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-tap-frame-removed.html View 2 chunks +38 lines, -10 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-tap-frame-removed-expected.txt View 1 chunk +21 lines, -2 lines 0 comments Download
A LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html View 1 1 chunk +77 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rick Byers
Zeeshan, PTAL
6 years, 4 months ago (2014-08-15 15:52:34 UTC) #1
Zeeshan Qureshi
lgtm with a nit. https://codereview.chromium.org/466143005/diff/1/LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html File LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html (right): https://codereview.chromium.org/466143005/diff/1/LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html#newcode33 LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html:33: // Tap at the right ...
6 years, 4 months ago (2014-08-15 18:33:17 UTC) #2
Rick Byers
https://codereview.chromium.org/466143005/diff/1/LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html File LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html (right): https://codereview.chromium.org/466143005/diff/1/LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html#newcode33 LayoutTests/fast/events/touch/gesture/gesture-tap-frame-scrollbar.html:33: // Tap at the right edge of the frame, ...
6 years, 4 months ago (2014-08-15 20:17:14 UTC) #3
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 4 months ago (2014-08-15 20:17:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/466143005/20001
6 years, 4 months ago (2014-08-15 20:17:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:29:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180389

Powered by Google App Engine
This is Rietveld 408576698