Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 466133003: Adds chromecast/tools/build to gyp_chromium paths for pymod_do_main. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds chromecast/tools/build to gyp_chromium paths for pymod_do_main. This allows for Chromecast's locale repack script (based off the implementation in chrome/) to specificy Chromecast-specific files. R=lcwu@chromium.org BUG=403104 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gyp_chromium View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gunsch
6 years, 4 months ago (2014-08-12 23:15:54 UTC) #1
lcwu1
lgtm
6 years, 4 months ago (2014-08-14 14:56:49 UTC) #2
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-14 16:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/466133003/1
6 years, 4 months ago (2014-08-14 16:02:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 19:22:17 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 21:15:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 289699

Powered by Google App Engine
This is Rietveld 408576698