Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/task_manager.h

Issue 466088: Revert 34146 - A place to store the pid>mach_port_t mapping.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/browser_render_process_host.cc ('k') | chrome/browser/task_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager.h
===================================================================
--- chrome/browser/task_manager.h (revision 34146)
+++ chrome/browser/task_manager.h (working copy)
@@ -46,15 +46,6 @@
virtual std::wstring GetTitle() const = 0;
virtual SkBitmap GetIcon() const = 0;
virtual base::ProcessHandle GetProcess() const = 0;
-#if defined(OS_MACOSX)
- // TODO(thakis): All the providers need to get these somewhere (child
- // processes need to IPC them to us via mach IPC at some point).
- // TODO(thakis): TMM needs to hand this on to ProcessMetrics.
- // TODO(thakis): ProcessMetrics then needs to call mach data collection apis
- // if it has the mach ports it needs.
- virtual mach_port_t GetMachHostPort() const { return 0; };
- virtual mach_port_t GetMachTaskPort() const { return 0; };
-#endif
virtual bool ReportsCacheStats() const { return false; }
virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const {
« no previous file with comments | « chrome/browser/renderer_host/browser_render_process_host.cc ('k') | chrome/browser/task_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698