Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 466063002: FrameView::paintContents should RELEASE_ASSERT(!needsLayout()) (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, skobes
Project:
blink
Visibility:
Public.

Description

FrameView::paintContents should RELEASE_ASSERT(!needsLayout()) We shouldn't ever ASSERT a condition and then handle its negation. If we can get here with layout dirty, we should crash so we can fix those cases. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 20:44:13 UTC) #1
esprehn
lgtm
6 years, 4 months ago (2014-08-12 20:49:01 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 4 months ago (2014-08-12 20:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/466063002/1
6 years, 4 months ago (2014-08-12 20:49:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 21:36:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:14:27 UTC) #6
Message was sent while issue was closed.
Change committed as 180108

Powered by Google App Engine
This is Rietveld 408576698