Issue 466053: Fix a crash bug on user script installation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466053: Fix a crash bug on user script installation (Closed)

Created:
11 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a crash bug on user script installation and add a test to make sure it doesn't happen again. Also, re-enable a test nearby. The history has been lost of why this was failing, so it may fail again, but at least we'll have data. Finally, fix a Greasemonkey compat issue. BUG=29298 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33945

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -12 lines)			Patch
M	chrome/browser/extensions/crx_installer.cc	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	3 chunks	+36 lines, -2 lines	1 comment	Download
M	chrome/renderer/user_script_slave.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Looks good, provided the below is ok. http://codereview.chromium.org/466053/diff/1/3 File chrome/browser/extensions/extensions_service_unittest.cc (right): http://codereview.chromium.org/466053/diff/1/3#newcode759 chrome/browser/extensions/extensions_service_unittest.cc:759: GURL("http://www.aaronboodman.com/scripts/user_script_basic.user.js"), This ...

11 years ago (2009-12-06 20:49:15 UTC) #3

Aaron Boodman

11 years ago (2009-12-06 21:39:38 UTC) #4

On 2009/12/06 20:49:15, abarth wrote:
> Looks good, provided the below is ok.
> 
> http://codereview.chromium.org/466053/diff/1/3
> File chrome/browser/extensions/extensions_service_unittest.cc (right):
> 
> http://codereview.chromium.org/466053/diff/1/3#newcode759
> chrome/browser/extensions/extensions_service_unittest.cc:759:
> GURL("http://www.aaronboodman.com/scripts/user_script_basic.user.js"),
> This doesn't actually touch your web site, right???

No, it doesn't send any requests. The source URL is required by CrxInstaller
because we use it to default some of the generated extension's configuration.

Expand Messages | Collapse Messages