Issue 466033002: Remove the extensibility flag. Instead just rely on hidden_string as indication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466033002: Remove the extensibility flag. Instead just rely on hidden_string as indication. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove the extensibility flag. Instead just rely on hidden_string as indication. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23164

Patch Set 2 : Addressed comment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -58 lines)			Patch
M	src/objects.h	View		3 chunks	+1 line, -11 lines	0 comments	Download
M	src/objects.cc	View	1	8 chunks	+12 lines, -40 lines	0 comments	Download
M	src/runtime.cc	View		3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a comment. https://codereview.chromium.org/466033002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/466033002/diff/1/src/objects.cc#newcode4853 src/objects.cc:4853: SetOwnPropertyIgnoreAttributes(object, name, value, DONT_ENUM); MUST_USE_RESULT, ...

6 years, 4 months ago (2014-08-13 10:31:10 UTC) #2

Toon Verwaest

6 years, 4 months ago (2014-08-18 14:27:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 23164 (tree was closed).

Expand Messages | Collapse Messages

Issue 466033002: Remove the extensibility flag. Instead just rely on hidden_string as indication. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages