Issue 466029: Revise run_webkit_test.PrepareListsAndPrintOutput() to keep accurate counts...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466029: Revise run_webkit_test.PrepareListsAndPrintOutput() to keep accurate counts... (Closed)

Created:
11 years ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revise run_webkit_test.PrepareListsAndPrintOutput() to keep accurate counts when we are sharding the tests. R=ojan@chromium.org TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33765

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -22 lines)			Patch
	M	webkit/tools/layout_tests/run_webkit_tests.py	View		5 chunks	+26 lines, -22 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years ago (2009-12-04 00:58:30 UTC) #2

LGTM with a couple nits

http://codereview.chromium.org/466029/diff/1/2
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/466029/diff/1/2#newcode213
webkit/tools/layout_tests/run_webkit_tests.py:213: test_expectations.SKIP)
nit: indent should be 4 spaces here.

http://codereview.chromium.org/466029/diff/1/2#newcode297
webkit/tools/layout_tests/run_webkit_tests.py:297: self._test_files = set(files)
Maybe add some comments here? It's confusing that we set _test_files, then set
it to something different after ParseExpectations. I get it that the point is to
calculate statistics correctly, but I had to stare at this code for a while to
figure that out (and to get that this wasn't actually running skipped tests).

Expand Messages | Collapse Messages