Issue 466016: linux: use TabContents to launch url for link in crash page...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466016: linux: use TabContents to launch url for link in crash page... (Closed)

Created:
11 years ago by kuan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

linux: use TabContents to launch url for link in crash page - used to use BrowserList::GetLastActive but that's null in chrome-frame release. - TabContents is passed into constructor and only if it's non-null is the link created. BUG=29034 TEST=verify that crash per bug report doesn't happen.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -26 lines)			Patch
M	chrome/browser/gtk/sad_tab_gtk.h	View	1 2	2 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/sad_tab_gtk.cc	View	1 2	4 chunks	+23 lines, -17 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages