Issue 466003002: ES6: Make Map/Set constructors support iterable values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466003002: ES6: Make Map/Set constructors support iterable values (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)

Modified:
6 years, 4 months ago

Reviewers:
Dmitry Lomov (no reviews), adamk

CC:
v8-dev, domenic

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

ES6: Make Map/Set constructors support iterable values Same for WeakMap/WeakSet https://bugs.ecmascript.org/show_bug.cgi?id=3111 BUG=v8:3508 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23091

Patch Set 1 #

Patch Set 2 : Add string value test too #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -4 lines)			Patch
M	src/collection.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/weak_collection.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/es6/collections.js	View	1 2 3	4 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

Trying to get one more fix in before the branch point.

6 years, 4 months ago (2014-08-12 16:14:11 UTC) #1

Dmitry Lomov (no reviews)

lgtm One suggestion for tests: test with strings as well

6 years, 4 months ago (2014-08-12 16:25:21 UTC) #2

arv (Not doing code reviews)

Committed patchset #4 manually as 23091 (presubmit successful).

6 years, 4 months ago (2014-08-12 20:09:51 UTC) #4

arv (Not doing code reviews)

6 years, 4 months ago (2014-08-12 21:28:36 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #4) has been created in
https://codereview.chromium.org/465023002/ by arv@chromium.org.

The reason for reverting is: TestSetConstructorIterableValue(WeakSet) fails on
x64.debug.

Expand Messages | Collapse Messages